Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Bug introduced in 696e69a Signed-off-by: Guillermo Ramos <[email protected]>

* Add comment to template_like_str method (cherry picked from commit a78859260a41725554105ab2ef8314a22b37d62f)

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

* Sunstone now correctly AND chains the hypervisor host requirement expression. Signed-off-by: Victor Hansson <[email protected]>

Signed-off-by: Ángel Cívico Martos <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

shown in each page Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

(cherry picked from commit a19325cbd5a3c4c7ffd810e847bf8980530529f2)

This commit adds support for "auto" setting for virtio queues of NICs. It follows the approach implemented by VIRTIO_BLK_QUEUES for DISKS. The commit also includes default setting and RSunstone implementation Signed-off-by: Kristian Feldsam <[email protected]>

Signed-off-by: Victor Hansson <[email protected]>

…3397) Signed-off-by: Guillermo Ramos <[email protected]>

Signed-off-by: Guillermo Ramos <[email protected]>

Signed-off-by: Ángel Cívico Martos <[email protected]>

Co-authored-by: Tino Vázquez <[email protected]>

tinova · 2025-02-04T15:16:10Z

src/datastore_mad/remotes/libfs.sh

+        # non-existent file or permission issue. Example:
+        #   Output from ls: "ls: cannot access 'image.raw': Permission denied"
+        #   After sed: "cannot access 'image.raw' (Permission denied)"
+        ls "$SRC" 2>&1 | sed -e 's/^ls: //' -e 's/: \(.*\)/ (\1)/'


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Using 'ls' for file operations in shell scripts can be problematic, potentially leading to incorrect processing of filenames with spaces or special characters. This may result in data loss or unintended consequences. To mitigate this, use the more robust 'find' command instead. 'find' offers flexible options for locating and processing files safely. For more on secure coding practices, see OWASP's Secure Coding Practices Quick Reference Guide: https://owasp.org/www-project-secure-coding-practices-quick-reference-guide/

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

tinova and others added 28 commits January 23, 2025 13:24

L #-: Rubocop 1.71.0

ed5f655

Fix failure propagation from mkfs (#3381)

aa085ef

Bug introduced in 696e69a Signed-off-by: Guillermo Ramos <[email protected]>

F #6342: Fix search for cluster VMs for MySQL (#3378)

91666f8

B #6831: Fix onevm save duplicated disks (#3382)

c6d3b8d

* Add comment to template_like_str method (cherry picked from commit a78859260a41725554105ab2ef8314a22b37d62f)

B #6833: Vnet review in Sunstone (#3383)

3be9775

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

F #6342: Add cluster quotas to sunstone (#3385)

7bf1f6f

Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

B #6845: Fix host sched req (#3387)

e1bb7f7

* Sunstone now correctly AND chains the hypervisor host requirement expression. Signed-off-by: Victor Hansson <[email protected]>

B #6830: Enable terminate from poweroff [master] (#3388)

c6f4fec

Signed-off-by: Ángel Cívico Martos <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

F #6639: Add data-cy for tests (#3391)

126b0c5

Co-authored-by: Tino Vázquez <[email protected]>

M #-: Add user group cypress identifier (#3395)

40e5d5e

Signed-off-by: Victor Hansson <[email protected]>

B #6728: Network values step in attach nic (#3392)

d36b8b4

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

M #-: Add devmode to Sunstone (#3400)

265f862

Signed-off-by: Victor Hansson <[email protected]>

F #6718: Define the number of rows (#3398)

538b110

shown in each page Co-authored-by: Tino Vázquez <[email protected]>

M #-: Add webpack build mode var (#3401)

9e1b8ad

Signed-off-by: Victor Hansson <[email protected]>

B #6790: Fix onehost show for single Hugepage (#3386)

631acb7

(cherry picked from commit a19325cbd5a3c4c7ffd810e847bf8980530529f2)

B #6828: Fix onetemplate cli options override CONTEXT section (#3377)

950f33c

F #6435: Fix compilation

dc86b5e

F #6435: Add NIC virtio queue switch (#3402)

4347e9b

Signed-off-by: Victor Hansson <[email protected]>

M #: Improve migration validation error message (#3408)

20f068d

F #6547: increment_flatten uses qemu-img commit instead of convert (#…

aac41f6

…3397) Signed-off-by: Guillermo Ramos <[email protected]>

B #6700: Improve error messages in fs_size (#3406)

235fd3c

Signed-off-by: Guillermo Ramos <[email protected]>

B #6830: Fixing VM terminate status (#3405)

8384884

Signed-off-by: Ángel Cívico Martos <[email protected]>

L #-: Rubocop 1.71.1

bbf82a4

B #6830: lint fix (#3409)

fc12305

Signed-off-by: Ángel Cívico Martos <[email protected]>

F #6826: Fix selected row (#3407)

93521db

Co-authored-by: Tino Vázquez <[email protected]>

F #6786: Fix issue creating Security Group (#3404)

d643dcd

Co-authored-by: Tino Vázquez <[email protected]>

B #-: Fix alertmanager.yml path for arm64 (#3410)

246a213

rsmontero force-pushed the master branch from 6493727 to 246a213 Compare February 4, 2025 15:10

tinova reviewed Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese commented Nov 29, 2021 •

edited

Loading

tinova Apr 25, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Feb 4, 2025

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openmilanese commented Nov 29, 2021 •

edited

Loading